CA-399669: Do not exit with error when IPMI readings aren't available #6261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
last-genius
approved these changes
Jan 29, 2025
This error made toolstack restarts fail. Because not all drivers have ipmi available, exit gracefully instead. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
The -I argument is to select a device, unsure why open is passed to it instead, but it doesn't seem to have any effect Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
psafont
force-pushed
the
private/paus/ipmissing
branch
from
774633f to
d7a5c7e
Compare
When the IPMI devices are missing, this is printed in the error line: $ /usr/bin/ipmitool -I open dcmi discover Could not open device at /dev/ipmi0 or /dev/ipmi/0 or /dev/ipmidev/0: No such file or directory Detect this situation so an appropriate warning can be printed. This needed changes in the function that executes the command, to be able to process stderr Example output: $ ./disco.exe [debug] Forking command /usr/bin/ipmitool dcmi discover [debug] Forked command /usr/bin/ipmitool dcmi discover [ info] DCMI discover: Could not open device at /dev/ipmi0 or /dev/ipmi/0 or /dev/ipmidev/0: No such file or directory [debug] Process 423018 exited normally with code 1 [ warn] IPMI DCMI power readings not available, stopping. Reason: IPMI devices are missing Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
psafont
force-pushed
the
private/paus/ipmissing
branch
from
d7a5c7e to
e24a5cc
Compare
lindig
approved these changes
Jan 29, 2025
On the DCMI daemon, ignore any kind of exception, rather than only end_of_line. On exec_cmd, close the file descriptor even if exception are raised while reading lines. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
lindig
approved these changes
Jan 30, 2025
|
I've rerun the binary with the new code in exec_cmd, works as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error made toolstack restarts fail.
Because not all drivers have ipmi available, exit gracefully instead.
Also try to extract the reason from the command's output and log it. This means that now functions that use Utils.exec_cmd now red the stderr of the command as well.
Fixes #6252